This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Handle failing case for update account cache in require #9989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
ascjones
approved these changes
Dec 3, 2018
ascjones
added
A8-looksgood 🦄
ngotchac
approved these changes
Dec 3, 2018
5chdn
pushed a commit
that referenced
this pull request
Dec 5, 2018
5chdn
added a commit
that referenced
this pull request
Dec 5, 2018
* version: bump beta to 2.2.4 * ci: move future releases to ethereum subdir on s3 (#10017) * ci: move future releases to ethereum subdir on s3 * ci: redesign s3 bucket logic * ci: use the releases bucket * Handle failing case for update account cache in require (#9989) * state: remove accidently merged test * state: remove merge leftovers
niklasad1
pushed a commit
that referenced
this pull request
Dec 16, 2018
insipx
pushed a commit
to insipx/parity-ethereum
that referenced
this pull request
Dec 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9838
Handle the case when updating account cache fails, but we're inside
RefMut.